[Bug 524545] Review Request: snacc - Sample Neufeld ASN.1 to C Compiler

bugzilla at redhat.com bugzilla at redhat.com
Wed Sep 23 09:33:36 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524545


Alex Musolino <musolinoa at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |musolinoa at gmail.com




--- Comment #1 from Alex Musolino <musolinoa at gmail.com>  2009-09-23 05:33:34 EDT ---
Hi Shakthi,

I have a few comments:

- The versioned shared libraries should not be in the devel package as they are
required by the snacc binary itself. (The *.so symlinks, however, should remain
in the devel package).

- The *.ans1 files are also required by snacc and so should be moved out of the
devel package.

- Some of the documentation (*.tex and *.bib) refers to the c-lib and c++-lib
APIs (these should go in snacc-devel) and some refer to the use of various
binaries in the snacc package (these should go in snacc).

- The C/C++ examples should go in devel package (they aren't being packaged at
the moment).

- The C/C++ header files for the c-lib and c++-lib should go into the devel
package.

- There's a spelling mistake in the description (s/dample/sample/).

Another idea might be to create libsnacc and libsnacc-devel packages for the c
and c++ libraries and put just the binaries in snacc. In fact, I think this
would be the optimal solution.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list