[Bug 472150] Review Request: coot - crystallographic macromolecular building toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472150


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




--- Comment #25 from Jason Tibbitts <tibbs at math.uh.edu>  2009-09-23 13:18:00 EDT ---
I'm not sure if you think this is ready to be reviewed or not, but I did a
"quick" build and while there are still 4300+ lines of rpmlint complaints, I
can ignore all of the shared-lib-calls-exit and undefined-non-weak-symbol
warnings and get something reasonable.

  coot.x86_64: W: name-repeated-in-summary Coot
I suggest s/Coot - t/T/ in the Summary:.

  coot.x86_64: W: incoherent-version-in-changelog 0.6-20090920svn2334
   ['0.6-1.20090920svn2334.fc12', '0.6-1.20090920svn2334']
The release changelog entry is missing a "1.".

  coot.x86_64: E: non-executable-script
   /usr/lib/python2.6/site-packages/coot/create_server.py 0644 /usr/bin/python
Is this file supposed to be called by anything?

  coot-debuginfo.x86_64: W: spurious-executable-perm
   /usr/src/debug/coot-0.6/surface/CXXFFTSolventMap.h
  coot-debuginfo.x86_64: E: script-without-shebang
   /usr/src/debug/coot-0.6/coot-surface/rgbreps.cc
Loads of these; the source code really shouldn't be executable.  A quick
find/chmod should fix it up.

  coot-devel.x86_64: W: no-documentation
Not a problem.

It looks like the upstream URL has moved.

Otherwise I did a cursory skim over the built packages and everything looks to
be in place.  I would need to do some testing, but if the above were cleaned up
and the licensing checks out then I'd say this package would be pretty close to
ready.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.