[Bug 524147] Review Request: libnetdevname -Development environment for libnetdevname

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524147





--- Comment #9 from Sandeep K. Shandilya <sandeep_k_shandilya at dell.com>  2009-09-23 14:14:43 EDT ---
(In reply to comment #4)
> I'm not really a fan of the API:
> 
> extern int netdev_pathname_to_name (char *);
> 
> This modifies the data you pass to it, which is ugly. Something like:
This should be fixed.
> 
> In the absence of kernel support, all /dev/net names throw errors. Passing it
> the existing /dev/net/tun also errors.
This should be fixed.
> 
> It only checks for /dev/net as a prefix. You pass it /dev/foo, or " bar", or
> other invalid device names... it returns them. 
if you pass /dev/foo as a param to the caller the lib will return the same
device (/dev/foo/*) to the ioctl call the call will fail. This is the same
behaviour without libnetdevname. I dont see why this is a problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.