[Bug 523326] Review Request: gnome-applet-window-picker - Window picker applet for GNOME

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 24 02:49:06 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523326





--- Comment #15 from Michel Alexandre Salim <michael.silvanus at gmail.com>  2009-09-23 22:49:05 EDT ---
(In reply to comment #14)
> Michel, AFAICS you did not fix any of the issues I pointed out in comment #7:
> - rpmlint is not clean

Not sure what you mean; it is clean here:
$ rpmlint
/home/michel/Download/gnome-applet-window-picker-0.5.6-2.fc12.i686.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint gnome-applet-window-picker
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint
/home/michel/Download/gnome-applet-window-picker-debuginfo-0.5.6-2.fc12.i686.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

> - make is not verbose
> - package doesn't require gnome-panel
> - ChangeLog missing from %doc

You're right on these; I misremembered having fixed all the TODO list. Updated
build will follow.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list