[Bug 525146] Review Request: PDCurses - Public Domain curses library

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 24 03:20:02 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525146





--- Comment #4 from Ralf Corsepius <rc040203 at freenet.de>  2009-09-23 23:20:01 EDT ---
(In reply to comment #3)
> something is probably using a
> hardcoded /lib,
Not quite. 

My issue originates from the fact that this package's toplevel Makefile.in does
not acknowledge libdir (and other *dir's.

When having fixed this, other bugs show up:

* DESTDIR handling is broken

* shared lib without SONAME.
IMHO, inacceptable, esp. not for a package which aims at implementing something
such kind of essential as a curses library.

* Several files from the devel-package conflict/clash with ncurses (MUSTFIX)

* The package installs an autoheader generated autoheader as
/usr/include/config.h (MUSTFIX).

* The devel-package lumps together x11 and sdl libraries.
IMO, the x11, sdl and other lib subsets should be split into separate
subpackages.

* The devel-package likely lacks deps on many other *-devel packages.
I haven't tried to check for details, yet.

* Shipping static libs. 
Jon, feel strongly encouraged not to ship them.

> Please clear the whiteboard when you have a package that builds.  
Urgh, what is this? More silly bureaucracy?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list