[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521909


Stefan Schulze Frielinghaus <stefan at seekline.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stefan at seekline.net




--- Comment #2 from Stefan Schulze Frielinghaus <stefan at seekline.net>  2009-09-24 04:14:07 EDT ---
A few comments about the spec file:

- Tabs aren't aligned properly

- I'm not sure about this comment:
# It still required for EPEL5
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

BuildRoot is required on Fedora too or do I miss something?

- What about this comment (line 15)?

#Requires:

- You should write a patch instead of using sed here:
# Hack to correct install on 64-bit systems.
sed -i ...

sed will return 0/no error if it substitutes something or even does nothing but
patch will fail if it cannot be applied. With a patch you are on the save side.

- The example package only contains 7 CPP files. Maybe you want to pack them
into the main package as docs too? What do you think?

- I guess it is a typo in the Changelog
Fix installation on 54-bit systems.

should be

Fix installation on 64-bit systems.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.