[Bug 523326] Review Request: gnome-applet-window-picker - Window picker applet for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523326





--- Comment #17 from Christoph Wickert <cwickert at fedoraproject.org>  2009-09-24 04:49:40 EDT ---
(In reply to comment #15)
> (In reply to comment #14)
> > Michel, AFAICS you did not fix any of the issues I pointed out in comment #7:
> > - rpmlint is not clean
> 
> Not sure what you mean; it is clean here:

Please see comment # 7 or run rpmlint on the srpm:
$ rpmlint Downloads/gnome-applet-window-picker-0.5.6-2.fc10.src.rpm 
gnome-applet-window-picker.src: W: mixed-use-of-spaces-and-tabs (spaces: line
1, tab: line 3)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

(In reply to comment #16)
> Not sure that is the correct reading. The guideline uses that versioned
> dependency as an example, and it actually recommended removing the version
> requirement, once the oldest supported Fedora release exceeds that requirement.

I read this different: Since non of the downsides apply to this package, a
versioned dep should be used here. However...

> In this case, since there is a SONAME dependency that will pull in the correct
> version of gnome-panel-libs, the correct version of gnome-panel would be pulled
> in as well (because of the same SONAME dependency between gnome-panel and
> libpanel-applet)

... I fully agree with you in this special case.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.