[Bug 524545] Review Request: snacc - Sample Neufeld ASN.1 to C Compiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524545





--- Comment #5 from Shakthi Kannan <shakthimaan at gmail.com>  2009-09-24 13:27:27 EDT ---
>From Comment #3:

- The snacc-libs package should not require the snacc package.

==> Now, snacc-libs has been removed.

- I've realised that it should be 'Sample' - Sample and Neufeld are the names
of the creators.  

==> FIXED.

>From Comment #4:

#001: I prefer to eliminate the -lib subpackage entirely.

==> DONE.

#002: Documentation:
*.tex and *.bib are pretty useless and inefficient for the user. I propose to
build a PDF out of it in the %prep section and ship only the PDF and not the
sources.

==> Already .ps file is being shipped in the -base package. I have removed
*.tex and *.bib files now.

#003: Directory ownership in base package 
%dir %{_includedir}/%{name}/

==> DONE.

#004: .m4
should this go to -devel ?
%{_datadir}/aclocal/snacc.m4

==> DONE.

#005: Patches naming should start with a %{name} prefix, if not they will
overwrite other patches with the same name.

==> DONE. These were upstream package names. Now, I have prepended %{name} to
them.

FYI: automake17 is provided by Fedora to maintain compatibility with own
software. The last real update of automake17 on Fedora is back in 2007. It is
recommended for upstream to tune their sources with respect to the newer
versions.

==> This is a very, very, very old package. Old, as in *1997*. Yet, it is a
very useful package. Upstream (Debian alone) has provided it so far. The
original code authors' FTP URL doesn't exist at all. Latest at:

SPEC: http://shakthimaan.fedorapeople.org/SPECS/snacc.spec
SRPM: http://shakthimaan.fedorapeople.org/SRPMS/snacc-1.3-3.fc11.src.rpm

Successful Koji builds at F-10, F-11 and EL-5 respectively:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1704234
http://koji.fedoraproject.org/koji/taskinfo?taskID=1704239
http://koji.fedoraproject.org/koji/taskinfo?taskID=1704255

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.