[Bug 525510] Review Request: geda-gaf - Design Automation toolkit for electronic design

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525510





--- Comment #6 from Rex Dieter <rdieter at math.unl.edu>  2009-09-24 14:16:48 EDT ---
Upstream sources verified:
$ md5sum gEDA-gaf-1.5.4.tar.gz
d99006d25bb7e61cbbdcc6c775861169  gEDA-gaf-1.5.4.tar.gz


1. MUST: remove rpaths. this snippet (in %prep after %setup) worked nicely for
me:

%if "%{_libdir}" != "/usr/lib"
sed -i -e 's|"/lib /usr/lib|"/%{_lib} %{_libdir}|' configure
%endif

2.  MUST: remove or document need for including the empty files related to the
rpmlint errors like:
geda-utils.x86_64: E: zero-length
/usr/share/doc/gEDA-gaf/utils/tests/gxyrs/outputs/offset_check_cols_match-pcb_example1.xy-error

I believe that should take care of all or a majority of the rpmlint items.

3.  MUST: add to libgeda-devel
Requires: pkgconfig
(for directory ownership)

4.  MUST: add desktop scriptlet to geda-gschem (it's .desktop file contains
MimeTypes= key):
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database

5.  SHOULD: use %posttrans optimized versions of scriptlets (icons in
particular), but not a big deal, adds complexity, but will also speed
installation and upgrades.


That's all I've got so far, mind fixing these up, and we can do another final
pass?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.