[Bug 525361] Review Request: python-wehjit - A Python web-widget library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525361


Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tcallawa at redhat.com
             Blocks|177841(FE-NEEDSPONSOR)      |
         AssignedTo|nobody at fedoraproject.org    |tcallawa at redhat.com
               Flag|                            |fedora-review+




--- Comment #1 from Tom "spot" Callaway <tcallawa at redhat.com>  2009-09-24 15:59:07 EDT ---
Review
=======

(Based on local testing with python-assets)

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines (python)
- license (GPLv3+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(6f95dd7756c8cb0e43cc5ce51af33cd40429536a2fee5e68144e899d3e55412a)
- package compiles on devel (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.