[Bug 503293] Review Request: webkitkde - QtWebKit bindings to KDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503293


Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Rex Dieter <rdieter at math.unl.edu>  2009-09-24 16:15:00 EDT ---
$ rpmlint *.rpm x86_64/*.rpm
6 packages and 0 specfiles checked; 0 errors, 0 warnings.

Looks good, only a couple of very small nitpicks

1.  the locale files look like they belong in the main webkitkde pkg
2.  webkitkde-devel probabaly should
Requires: kdelibs4-devel
3.  %install could use
make install/fast ...
4.  leave out the 
"If WebKit does not show up in Konqueror, run 'kbuildsycoca4'.
comments, shouldn't be needed

But I won't consider any of these review blockers, but please address them
prior to building.


Otherwise,

Source is documented
scriptlets good
macro usage consistent (could use %%_kde4_appsdir}
tested to function

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.