[Bug 525210] Review Request: rubygem-trollop - A command-line option parsing library for ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525210





--- Comment #4 from Jan Klepek <jan.klepek at hp.com>  2009-09-25 01:17:08 EDT ---
(In reply to comment #2)
> Well, the version is 1.14, 1.14.2.
> 
> For 1.14-0:
> * License
>   - Well README says the license is the same as Ruby,
>     lib/trollop.rb says it is under GPLv2. So the license
>     tag should be "GPLv2"
> 
> * Redundant macro
>   - Is the definition of %ruby_sitelib needed?
> 
> * %check
>   - As this gem contains test/ directory, please add %check
>     stage and execute a test program.
> 
> * Directory ownership issue
>   - The directory %geminstdir itself is not owned by any packages.  

-all fixed
Spec URL: http://hpejakle.fedorapeople.org/packages/rubygem-trollop.spec
SRPM URL:
http://hpejakle.fedorapeople.org/packages/rubygem-trollop-1.14-1.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.