[Bug 525151] Review Request: CLconverter - A simple command line tool for converting units

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525151


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de




--- Comment #9 from Martin Gieseking <martin.gieseking at uos.de>  2009-09-25 02:29:20 EDT ---
A few additional remarks from me: :)

- the license tag must be GPLv3+ (because of the addition "or
    (at your option) any later version" in the source headers)

- the given URL doesn't seem to be up-to-date (404)

- append the CFLAGS assignment to the make statement:
  make CLconverter CFLAGS="${RPM_OPT_FLAGS}" 

- in %files, replace %defattr(-,root,root) by %defattr(-,root,root,-)

- you should add a changelog entry with a short summary about the changes for
each revision, so that the file history can be reproduced

- change the file permissions of the tarball to 0644  


$ rpmlint /var/lib/mock/fedora-11-x86_64/result/CLconverter-*
CLconverter.src: W: strange-permission CLconverter-0.4.7.tar.gz 0755
CLconverter-debuginfo.x86_64: E: debuginfo-without-sources
3 packages and 0 specfiles checked; 1 errors, 1 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.