[Bug 522169] Review Request: netplug - Daemon that responds to network cables being plugged in and out

Fri Sep 25 09:05:31 UTC 2009

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522169

Dan Horák <dan at danny.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Dan Horák <dan at danny.cz>  2009-09-25 05:05:28 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     38ce1ae1815a74d6ab3e7ee0e034714267456d16  netplug-1.2.9.1.tar.bz2
OK package meets naming and versioning guidelines.
OK* specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (GPLv2). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
Ok compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- %{_initddir} is the preferred variant of the macro, works on F-10+
- rpmbuild takes care of buildroot

This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.