[Bug 492810] Review Request: RabbIT - proxy for a faster web

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492810





--- Comment #18 from Simon Wesp <cassmodiah at fedoraproject.org>  2009-09-25 14:14:18 EDT ---
------ 
>   ~ make your init.d-script conform
Conform to what??
------
http://fedoraproject.org/wiki/Packaging:SysVInitScript
you are missing a reload function


-----
>   ~ add a logrotate for log-files
For what if it has inner mechanism of log rotation?? Just rpmlint can't known
about this.
-----
You can read some stuff about logrotate in the logrotate manpage

--- RabbIT.spec
Source1:  %{lname}.logrotate
..
..
# install log rotation stuff
mkdir -p %{buildroot}/etc/logrotate.d
install -pm0644 %{SOURCE1} \
 %{buildroot}/etc/logrotate.d/%{lname}
..
..
%attr(600,%{lname},root) %ghost %{_localstatedir}/log/%{name}/main_run.log
..
%config(noreplace) %{_sysconfdir}/logrotate.d/%{lname}
---
please don't give read and execute acess to users
log files dont need execute (for root, too)

--- rabbit.logrotate
/var/log/rabbit/*log {
    weekly
    notifempty
    missingok
}
---

After you changed that, package should be okay.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.