[Bug 514221] Review Request: ovirt-node - The oVirt Node daemons/scripts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514221





--- Comment #8 from David Huff <dhuff at redhat.com>  2009-09-25 15:55:17 EDT ---
New spec...
http://huff.fedorapeople.org/ovirt-node.spec

scratch build...
https://koji.fedoraproject.org/koji/taskinfo?taskID=1707859

output form rpmlint. I fixed most of the issues the ones remaing are mainly
with our init scripts which are not triditional initscripts.

Most issues are with /etc/rc.d/init.d/ovirt-functions, which is not an init
script at all but helper file like /etc/init.d/functions, no really sure hwo to
treat in it the spec.

ovirt-node.x86_64: W: non-conffile-in-etc /etc/rc.d/init.d/ovirt-functions
ovirt-node.x86_64: E: script-without-shebang /etc/rc.d/init.d/ovirt-functions
ovirt-node.x86_64: E: non-executable-script /etc/rc.d/init.d/ovirt-functions
0644 None
ovirt-node.x86_64: E: init-script-non-executable
/etc/rc.d/init.d/ovirt-functions
ovirt-node.x86_64: W: no-reload-entry /etc/rc.d/init.d/ovirt-functions
ovirt-node.x86_64: E: no-chkconfig-line /etc/rc.d/init.d/ovirt-functions
ovirt-node.x86_64: E: subsys-not-used /etc/rc.d/init.d/ovirt-functions

The remain warrning are with our outher initscripts which are scripts thate are
just run ones like  /etc/rc.d/init.d/network and do not really need are
reload.....

ovirt-node.x86_64: W: service-default-enabled /etc/rc.d/init.d/ovirt-firstboot
ovirt-node.x86_64: W: no-reload-entry /etc/rc.d/init.d/ovirt-firstboot
ovirt-node.x86_64: W: no-reload-entry /etc/rc.d/init.d/ovirt-post
ovirt-node.x86_64: W: no-reload-entry /etc/rc.d/init.d/ovirt
ovirt-node.x86_64: W: no-reload-entry /etc/rc.d/init.d/ovirt-early


Any suggestions on /etc/rc.d/init.d/ovirt-functions

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.