[Bug 525814] Review Request: fusecompress1 - Utilities to help migrate off of fusecompress-1.x

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525814





--- Comment #2 from Toshio Ernie Kuratomi <a.badger at gmail.com>  2009-09-25 19:48:43 EDT ---
Thanks for reviewing!

(In reply to comment #1)
> 1) The name might be missleading as it isn't really fusecompress1 but kind of a
> migration tool, fusecompress1-migrate would be approriate to avoid confusion.

How about fusecompress_offline1 since that's the name of the utility it
installs?

> 2) Use install rather than mv

mv is being used to rename two files that were installed by make install. 
(renaming the binary from fusecompress_offline to fusecompress_offline1 and the
man page from fusecompress_offline.1 to fusecompress_offline1.1)  This seems
proper to me.  Do you agree or is there some way to use install in that
situation that's better?

> 3) Well the rpmlinit messages is clear, remove the +x from the source files.

Fixed

SPEC: http://toshio.fedorapeople.org/packages/fusecompress_offline1.spec
SRPM:
http://toshio.fedorapeople.org/packages/fusecompress_offline1-1.99.19-6.fc11.src.rpm

http://koji.fedoraproject.org/koji/taskinfo?taskID=1708383

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.