[Bug 524468] Review Request: gstreamer-plugins-espeak - A simple gstreamer plugin to use espeak

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524468


Guido Grazioli <guido.grazioli at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Guido Grazioli <guido.grazioli at gmail.com>  2009-09-26 06:10:55 EDT ---
OK - rpmlint output

../SPECS/gstreamer-plugins-espeak.spec:28: W: configure-without-libdir-spec
3 packages and 1 specfiles checked; 0 errors, 1 warnings.

It can be safely ignored, as rpmlint thinks you are running configure here:
sed -i 's/NANO=1/NANO=0/g' ./configure

(rpmlint reports the warn even if you comment the line, you could check if a
bug report has been already opened about that, i only found this one: 
bug 462360)

However, if you modify the line to:
sed -i 's/NANO=1/NANO=0/g' configure
rpmlint doesnt complain anymore.

As a side note, it's not a must, but maybe changing configure.ac
and running autoconf before building is somewhat more elegant.

OK - The package must be named according to the Package Naming Guidelines.
OK - The spec file name must match the base package %{name}
OK - The package must meet the Packaging Guidelines
OK - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc
OK - The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines (license is LGPLv2+)
OK - Every binary RPM package which stores shared library files must
call ldconfig in %post and %postun 
OK - The package MUST successfully compile and build
koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1708305
OK - The spec file must be written in American English.
OK - The spec file for the package MUST be legible.
OK - The sources used to build the package must match the upstream source, as
provided in the spec URL. 
4e4a2d2363c50be72ed5d26a319439c3  gst-plugins-espeak-0.3.3.tar.bz2
NA - The spec file MUST handle locales properly (no translations)
NA - package not relocatable
OK - A package must own all directories that it creates
OK - A Fedora package must not list a file more than once in the spec file's
%files listings
OK - Permissions on files must be set properly
OK - Each package must have a %clean section
OK - Each package must consistently use macros
OK - The package must contain code, or permissable content (no content)
NA - Large documentation files must go in a -doc subpackage (no large doc)
OK - If a package includes something as %doc, it must not affect the runtime of
the application
NA - Header files must be in a -devel package (no devel package)
NA - Static libraries must be in a -static package (no static package)
NA - Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
OK - Packages must NOT contain any .la libtool archives
NA - Packages containing GUI applications MUST include a .desktop file 
OK - No file conflicts with other packages and no general names.
OK - At the beginning of %install, each package MUST run rm -rf %{buildroot}
OK - All filenames in rpm packages must be valid UTF-8
OK - The package does not yet exist in Fedora. The Review Request is not a
duplicate.
OK - %{?dist} tag is used in release


Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.