[Bug 516059] Review Request: dokuwiki - Standards compliant simple to use wiki

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516059


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

Bug 516059 depends on bug 516058, which changed state.

Bug 516058 Summary: Review Request: php-email-address-validation - A PHP class for validating email addresses
https://bugzilla.redhat.com/show_bug.cgi?id=516058

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Status|ASSIGNED                    |ON_QA
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED



--- Comment #3 from Steve Traylen <steve.traylen at cern.ch>  2009-09-26 14:18:54 EDT ---
Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the webapp specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
     supported architecture.
     http://koji.fedoraproject.org/koji/taskinfo?taskID=1709685
 [x] Rpmlint output:
dokuwiki.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 38, tab: line 1)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
 > Okay since this is in a sed line.
 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other
legal
     requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [x] If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
     Not present and not included.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
     in the spec URL.
c75c4781b8698041c3c9b6b0fec2ac2e  dokuwiki-2009-02-14b.tgz
c75c4781b8698041c3c9b6b0fec2ac2e  ../SOURCES/dokuwiki-2009-02-14b.tgz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
     application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Koji build done.
 [x] Package should compile and build into binary rpms on all supported
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.