[Bug 525796] Review Request: winwrangler - Small desktop daemon to perform advanced window manipulations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525796





--- Comment #4 from Guido Grazioli <guido.grazioli at gmail.com>  2009-09-27 12:10:34 EDT ---
QUEUED - The package MUST successfully compile and build

The package needs gtk2-devel >= 2.17.11 to build. 
(Commit here: http://osdir.com/ml/svn-commits-list/2009-09/msg00926.html)
I cannot build the package locally as i have no functional rawhide here and
latest version for F-11 is 2.16.6. To build in koji you will have to wait for
libgtkhotkey to be pushed in.

QUEUED - rpmlint output

OK - The package must be named according to the Package Naming Guidelines.
OK - The spec file name must match the base package %{name}
OK - The package must meet the Packaging Guidelines
OK - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc
OK - The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines (license is GPLv3)
NA - Every binary RPM package which stores shared library files must
call ldconfig in %post and %postun 
QUEUED - The package MUST successfully compile and build
Must wait dependency to be pushed to build in koji
OK - The spec file must be written in American English.
OK - The spec file for the package MUST be legible.
OK - The sources used to build the package must match the upstream source, as
provided in the spec URL. 
bfb69578d335a2988f4018e3a186e590  winwrangler-0.2.3.tar.gz
OK - The spec file MUST handle locales properly (find_lang used)
NA - package not relocatable
OK - A package must own all directories that it creates
OK - A Fedora package must not list a file more than once in the spec file's
%files listings
OK - Permissions on files must be set properly
OK - Each package must have a %clean section
OK - Each package must consistently use macros
OK - The package must contain code, or permissable content 
NA - Large documentation files must go in a -doc subpackage (no large doc)
OK - If a package includes something as %doc, it must not affect the runtime of
the application
NA - Header files must be in a -devel package (no devel package)
NA - Static libraries must be in a -static package (no static package)
NA - Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
NA - Packages must NOT contain any .la libtool archives
OK - Packages containing GUI applications MUST include a .desktop file (desktop
file included in SRPM as Source1 and installed correctly, gtk-update-icon-cache
used)
OK - No file conflicts with other packages and no general names.
OK - At the beginning of %install, each package MUST run rm -rf %{buildroot}
OK - All filenames in rpm packages must be valid UTF-8
OK - The package does not yet exist in Fedora. The Review Request is not a
duplicate.
OK - %{?dist} tag is used in release

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.