[Bug 508922] Review Request: system-config-selinux - GUI Code for system-config-selinux, polgen, and lockdown

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508922





--- Comment #15 from David Timms <dtimms at iinet.net.au>  2009-09-27 18:13:43 EDT ---
(In reply to comment #14)
> 1. I made the project name on the wiki lowercase (you can explain to me why
> that was your first complaint later)
Either the package name or the web site got the name wrong as
System-Config-Selinx, rather than
System-Config-Selinux
; I assumed it was the web site, but wanted to clarify, I see you fixed the
spelling anyhow.

I haven't performed build, functionality, or md5sum checks yet, will do that
maybe in the next day.

> 6. 2 line breaks between all sections now.
That looks good, except the changelog entries (they are all one section, and
typically have single line breaks between each entry, like the break between
sept27 and previous). 

Also, the version on each changelog entry is allowed to be one of:
* Tue Aug 24 2004 Alexander Larsson <alexl at redhat.com> - 2.7.4-2
* Thu Aug 19 2004 Alex Larsson <alexl at redhat.com> 2.7.4-1
see https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

You can leave this until there is more to update.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.