[Bug 525786] Review Request: popfile - Automatic Email Classification

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525786


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #4 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-09-28 12:29:11 EDT ---
Almost okay.

* Documents directory
  - Usually documents (like "license" text) should be installed
    under %{_defaultdocdir}/%{name}-%{version}.

    If this package really wants document files to be unstalled
    under %{_datadir}/%{name}, it can be accepted. Otherwise
    please consider to move them to the directory used on Fedora
    by default.

  ! Note
-------------------------------------------------------------
%files
%doc license
-------------------------------------------------------------
    will do this automatically.

* Empty scriptlets
  - Please remove %pre stage completely. Currently %pre stage
    essentially does nothing, however leaving this calls
    unneeded shell process (however Fedora suggests to leave
    %build stage even if this is empty)

* logrotate file
  - rpmlint says:
-------------------------------------------------------------
popfile.noarch: W: log-files-without-logrotate /var/log/popfile
-------------------------------------------------------------
    Please consider to create logrotate file (not a blocker).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.