[Bug 475861] Review Request: gnustep-gui - The GNUstep gui library

bugzilla at redhat.com bugzilla at redhat.com
Mon Sep 28 19:19:46 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475861





--- Comment #9 from Michel Alexandre Salim <michael.silvanus at gmail.com>  2009-09-28 15:19:44 EDT ---
Correct URL:
http://www.herr-schmitt.de/pub/gnustep-gui/gnustep-gui-0.16.0-3.fc11.src.rpm

FIX rpmlint

$ rpmlint ./x86_64/gnustep-gui*0.16.0-3*
gnustep-gui-devel.x86_64: W: no-documentation
gnustep-gui-libs.x86_64: W: shared-lib-calls-exit
/usr/lib64/libgnustep-gui.so.0.16.0 exit at GLIBC_2.2.5

this is unusual, but probably ok

4 packages and 0 specfiles checked; 0 errors, 2 warnings.
[michel at erdos RPMS]$ rpmlint ./noarch/gnustep-gui*0.16.0-3*
gnustep-gui-doc.noarch: E: postin-without-install-info
/usr/share/info/AppKit.info.gz
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

==> add another install-info line for AppKit.info

OK source matches upstream

$ sha1sum SRPMS/gnustep-gui-0.16.0.tar.gz SOURCES/gnustep-gui-0.16.0.tar.gz 
cc0a14f700a3736b8e4113d3ad80ed6f979d60be  SRPMS/gnustep-gui-0.16.0.tar.gz
cc0a14f700a3736b8e4113d3ad80ed6f979d60be  SOURCES/gnustep-gui-0.16.0.tar.gz


FIX build ought to be verbose (I missed this for gnustep-base too, the same fix
    applies)
  add the flag 'messages=yes' to the invocation of make



Several trivial fixes:
- summary and description (base and doc) should say GUI not gui
  ==> copy newer description from README; this is fixed upstream
- library and devel subpackages: "Package" should not be capitalized
- library and devel subpackages have very short descriptions

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list