[Bug 518636] Review Request: django-reversion - Django extension that provides version control capabilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518636


Michel Alexandre Salim <michael.silvanus at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |michael.silvanus at gmail.com
         AssignedTo|nobody at fedoraproject.org    |michael.silvanus at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Michel Alexandre Salim <michael.silvanus at gmail.com>  2009-09-28 15:56:29 EDT ---
Hello -- welcome to the world of Fedora packagers!

Some preliminary suggestions -- full review to follow, after which I can
sponsor you. If you could also provide links to reviews you have done, or other
packaging work (preferably RPM-based), even if these are not part of any
distribution, please do so.

- for the Source0: field, you want to include the full URL. e.g.
http://django-reversion.googlecode.com/files/%{name}-%{version}.tar.gz

- URL at the end of %description is redundant; rpm -qi will show it

- %setup -q is enough; it defaults to -n %{name}-%{version}

- include release number in the Changelog. If you use Emacs, the easiest way to
  generate a changelog entry is to use M-x rpm-add-changelog-entry (you can
  tab-complete after rpm-add)

Use rpmlint on the source and binary RPMs after each update to make sure there
are no issues -- and let me know if there is anything unclear. e.g. using your
spec, I get this:

$ rpmlint ../RPMS/noarch/django-reversion-1.1.2-1.fc12.noarch.rpm 
django-reversion.noarch: W: incoherent-version-in-changelog 1.1.2
['1.1.2-1.fc12', '1.1.2-1']

==> missing revision number (you can skip the %{?dist} part)

django-reversion.noarch: W: no-documentation
==> %files should have a %doc section. In this case, it appears the author
    did not provide any documentation at all, so you'd want to ask him to
bundle
    a license file with a tarball. For now, you can package the PKG-INFO file,
    since it comes from upstream and at least mentions the BSD license (though
    it also says LICENSE UNKNOWN).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.