[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521909





--- Comment #18 from Michael Schwendt <mschwendt at gmail.com>  2009-09-29 08:26:38 EDT ---
Splitting-hairs. You *could* include these tiny example source files in the
-devel package, but it really doesn't matter. It's cleaner to treat them as
documentation.

* The examples don't even build from scratch. They fail. You haven't tried to
compile them at all, which shows how unimportant they are to you. Most of them
are missing to include the cstdio header.

* The examples won't build inside their directory as only superuser root can
write to that directory. A normal user would need to copy them somewhere else.

* The examples don't even work if built without modifications, since some
contain only examplary values instead of real-life configuration values. They
are really just an add-on to the API documentation, not ready-to-run demos.

* Documentation packages also need a program that can display the
documentation. For example, a browser for HTML pages. Or a viewer for PDF
files. Such requirements are _not_ hardcoded as package dependencies.

* All -devel packages need a matching development environment, i.e. compilers
and tools, standard libraries. Such requirements are _not_ hardcoded as package
dependencies either.

* A packaging issue is left, too.
  This is Fedora's cmake invocation with the %{cmake} macro:

 %build
-CFLAGS="%{optflags}" CXXFLAGS="%{optflags}" cmake .
+%{cmake} .
 make all %{?_smp_mflags}

Look at "rpm --eval %cmake" to see what it does. Not only does it set the
optflags, it also increases verbosity to fill the build log with relevant
output.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.