[Bug 459855] Review Request: ncid - Caller ID distributed over a network to a variety of devices
bugzilla at redhat.com
bugzilla at redhat.com
Tue Sep 29 15:33:25 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=459855
--- Comment #16 from Jarod Wilson <jarod at redhat.com> 2009-09-29 11:33:21 EDT ---
At a quick glance:
- %preun client uses an explicit list of services to stop, but %postun client
uses a somewhat odd method of looking at /usr/share/ncid/ncid-* to figure out
what to condrestart. I'd make %postun client use the same list as %preun
client.
- The %files lists still use /etc, that should be replaced with %{_sysconfdir}
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list