[Bug 550594] Review request: themonospot-base - core component of Themonospot suite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550594


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #11 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2010-01-01 11:10:04 EDT ---
For 0.8.2-2

* Unversioned Obsoletes
-------------------------------------------------------------
Obsoletes: themonospot
-------------------------------------------------------------
  - This unversioned Obsoletes statement may cause problem
    in the future (for example when "themonospot" comes back).
    It is highly recommended to specify the version for
    Obsoletes.
    On Fedora the following is sufficient (so change to below)
-------------------------------------------------------------
Obsoletes: themonospot < 0.8.0
-------------------------------------------------------------

    For this package I don't think adding virtual Provides
    for themonosport is strictly needed, however you may want
    to add the following:
-------------------------------------------------------------
Provides: themonospot = %{version}
-------------------------------------------------------------

* %description
-------------------------------------------------------------
themonospot-base is core package for themonospot system. It install:
    - themonospot-base mono assembly in GAC (use from other gui applications)
-------------------------------------------------------------
  - Again I am not familiar with mono, however your %changelog says:
-------------------------------------------------------------
* Wed Dec 30 2009 Armando Basile <hmandevteam at gmail.com> 0.8.2-1
- removed GAC use
-------------------------------------------------------------
    So this description may be outdated. Please fix this if necessary.

Other things are okay. Please fix above when importing into
Fedora CVS.

-------------------------------------------------------------
    This package (themonospot-base) is APPROVED by mtasaka
-------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.