[Bug 518318] Review Request: vanessa_socket - Simplify TCP/IP socket operations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518318





--- Comment #5 from Joshua Roys <roysjosh at gmail.com>  2010-01-04 10:52:28 EDT ---
(In reply to comment #4)
> > Why tabsize of 5?  It just seems non-standard :)  Don't suppose I could
> > convince you to use 4 or 8 or to just use spaces?
> https://fedoraproject.org/wiki/PavelAlexeev/tabsize

That's fine - it is your choice at this point.  I was just curious.

> > Do we really need that ugly looking thing above the %configure?
This was a separate question.  Why do we need to run all the autotools by hand?
 Does it still work if we remove them?  Do we need to mess with CFLAGS?

You updated the BuildRequires but not the Requires?

You have some single %s in the changelog, 0.0.7-3, line 2, at the end.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.