[Bug 532286] Review Request: treeline - Store almost any kind of information in a tree structure

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532286


Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschwendt at gmail.com




--- Comment #4 from Michael Schwendt <mschwendt at gmail.com>  2010-01-04 16:59:35 EDT ---
> have seen that there's a -libs subpackage?

Yes.  The package contents are .noarch nevertheless.


And it's broken currently:

$ sudo rpm -i treeline-1.2.4-1.fc12.i686.rpm
$ treeline 
/usr/bin/python: can't open file
'/usr/lib/python2.6/site-packages/treeline/treeline.py': [Errno 2] No such file
or directory

What's the rationale for this strange -libs split-off?


> Requires:       PyQt4, python, qt, aspell

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
plus: "qt" is redundant, and treeline doesn't need it directly anyway
plus: "python" is redundant, because the Python ABI dependency is automatic for
the treeline module

> BuildRequires:  python, python-devel, desktop-file-utils, dos2unix
> PyQt4, qt, aspell

Same redundancy here. python-devel requires python, PyQt4 requires qt


The fix for --short-circuit builds:

--- treeline.spec.orig  2010-01-04 22:58:05.000000000 +0100
+++ treeline.spec       2010-01-04 22:58:26.000000000 +0100
@@ -67,7 +67,7 @@
 rm -rf %{buildroot}
 python install.py -b %{buildroot}

-mkdir __doc
+rm -rf __doc ; mkdir __doc
 mv  %{buildroot}%{_datadir}/doc/%{name}/* __doc
 rm -rf %{buildroot}%{_datadir}/doc/%{name}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.