[Bug 452321] Review Request: PyGreSQL - Python client library for PostgreSQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=452321


Rakesh Pandit <rpandit at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |rpandit at redhat.com
               Flag|                            |fedora-review+




--- Comment #24 from Rakesh Pandit <rpandit at redhat.com>  2010-01-07 07:59:22 EDT ---
[x] - Ok, [-] Needs input, [na] - Not Applicable

[x] http://koji.fedoraproject.org/koji/taskinfo?taskID=1907408 - Builds fine
[x] rpmlint messages: fine

Rpmlint Messages:
PyGreSQL.x86_64: E: non-executable-script
/usr/lib64/python2.6/site-packages/pg.py 0644 /usr/bin/env
PyGreSQL.x86_64: E: non-executable-script
/usr/lib64/python2.6/site-packages/pgdb.py 0644 /usr/bin/env

Can be ignored

[x] Source original

Upstream:
[rakesh at simu review]$ sha1sum PyGreSQL-3.8.1.tgz 
341d14beb99e88f779657db3ce146b41c897f975  PyGreSQL-3.8.1.tgz

SRPM:
[rakesh at simu review]$ sha1sum PyGreSQL-3.8.1-2.fc13.src/PyGreSQL-3.8.1.tgz 
341d14beb99e88f779657db3ce146b41c897f975 
PyGreSQL-3.8.1-2.fc13.src/PyGreSQL-3.8.1.tgz

[x] Package Name: fine (matches with upstream)
[x] License fine (may you just request upstream (yourself ;) to just add a bit
explanation in some README file and provide license txt)
[x] Spec name fine
[x] Spec is legible and written in American English
[x] Package successfully builds on primary archs
[x] Debuginfo file seems to be fine
[x] Permissions of files file
[x] All folders which are created are owned correctly
[x] Docs are present and appropriately kept
[x] Files names in package valid UTF-8
[x] python-devel present
[x] provides and obsoletes seem to be fine
[-] In python_sitearch definition use %global and not %define (deprecated)
[x] Python eggs build from source
[x] byte compiled files included

Summary:
Just check one point with [-]. Everything seems to be fine. Before importing
this may you make sure that you have removed PyGreSQL from the postgresql main
package and corresponding updated to latest.

APPROVED

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.