[Bug 553281] Review Request: netsniff-ng - high performance linux network sniffer for packet inspection
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jan 7 19:02:28 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=553281
--- Comment #5 from Terje Røsten <terjeros at phys.ntnu.no> 2010-01-07 14:02:27 EDT ---
a) too long lines in %description (> 80)
b) mixing $RPM_BUILD_ROOT and %{buildroot}
c) no need to mark man pages as %doc, done by rpmbuild itself
d) I believe it's better to chmod 0644 man page last in %install than using
%attr in %files. Better to save %attr for special cases.
In all, nice work.
Do you have a Fedora account? If not create one, and try to do
a koji scratch build and post a koji link (makes it more easy for the reviewer)
More info here:
http://fedoraproject.org/wiki/PackageMaintainers/UsingKoji#Scratch_builds_2
koji build --scratch dist-f13 netsniff-ng-0.5.4.1-2.fc12.src.rpm
I created the patch so it could be sent upstream.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list