[Fedora-packaging] Can you review my specfile: rsnapshot.spec

[Gavin Henry]

Dear all,

Not sure if I should e-mail the Extras list or this, so here goes:

Anything stupid that I have missed?

I have imported the srpm to Extras devel.

----------
Name:           rsnapshot
Summary:        Local and remote filesystem snapshot utility
Version:        1.2.1
Release:        1
License:        GPL
Group:          Applications/System
Url:            http://www.rsnapshot.org
Source0:        http://www.rsnapshot.org/downloads/rsnapshot-1.2.1.tar.gz
Patch0:         rsnapshot.patch
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)
Requires:       perl, rsync, ssh
AutoReqProv:    no

%description
This is a remote backup program that uses rsync
to take backup snapshots of filesystems.
It uses hard links to save space on disk.

%prep
rm -rf %{buildroot}

%setup

%patch

%build
%configure

%install
install -d %{buildroot}/%{_bindir}
install -m 755 rsnapshot %{buildroot}/%{_bindir}/rsnapshot

install -d %{buildroot}/%{_mandir}/man1
install -m 644 rsnapshot.1 %{buildroot}/%{_mandir}/man1/

install -d %{buildroot}/%{_sysconfdir}
install -m 644 rsnapshot.conf.default
%{buildroot}/%{_sysconfdir}/rsnapshot.conf.default
install -m 600 rsnapshot.conf.default
%{buildroot}/%{_sysconfdir}/rsnapshot.conf

%post
#
# upgrade rsnapshot config file
#
RSNAPSHOT_CONFIG_VERSION=`%{_bindir}/rsnapshot check-config-version`
if test $? != 0; then
	echo "Error upgrading %{_sysconfdir}/rsnapshot.conf"
fi

if test "$RSNAPSHOT_CONFIG_VERSION" = "1.2"; then
	# already latest version
	exit 0
fi

if test "$RSNAPSHOT_CONFIG_VERSION" = "unknown"; then
	%{_bindir}/rsnapshot upgrade-config-file
	RETVAL=$?
	exit $RETVAL
fi

echo "Error upgrading %{_sysconfdir}/rsnapshot.conf. Config format unknown!"
exit 1


%clean
rm -rf %{buildroot}

%files
%defattr(-,root,root)
%verify(user group mode md5 size mtime) %doc AUTHORS COPYING ChangeLog
README INSTALL TODO
%verify(user group mode md5 size mtime) %config
%{_sysconfdir}/rsnapshot.conf.default
%verify(user group mode) %config(noreplace) %{_sysconfdir}/rsnapshot.conf
%verify(user group mode md5 size mtime) %{_bindir}/rsnapshot
%verify(user group mode md5 size mtime) %{_mandir}/man1/rsnapshot.1*

%changelog
* Tue Apr 12 2005 Gavin Henry <ghenry at suretecsystems.com>
- Cleaned up a lot and imported to Fedora Extras

* Sun Jan 29 2005 Nathan Rosenquist <nathan at rsnapshot.org>
- Added upgrade script

* Sat Jan 22 2005 Nathan Rosenquist <nathan at rsnapshot.org>
- Added --with-du option

* Thu Jan 15 2004 Nathan Rosenquist <nathan at rsnapshot.org>
- Added "AutoReqProv: no" for SuSE compatibility

* Fri Dec 26 2003 Nathan Rosenquist <nathan at rsnapshot.org>
- Added util-linux dependency, and --with-logger= option

* Fri Dec 19 2003 Nathan Rosenquist <nathan at rsnapshot.org>
- now fully support autoconf

* Tue Dec 16 2003 Nathan Rosenquist <nathan at rsnapshot.org>
- changed rsnapshot.conf to rsnapshot.conf.default from the source tree

* Wed Nov 05 2003 Nathan Rosenquist <nathan at rsnapshot.org>
- Removed fileutils dependency, added verification info

* Tue Nov 04 2003 Nathan Rosenquist <nathan at rsnapshot.org>
- fixed anonymous rsync error

* Thu Oct 30 2003 Nathan Rosenquist <nathan at rsnapshot.org>
- update to 1.0.3

* Tue Oct 28 2003 Carl Wilhelm Soderstrom <chrome at real-time.com>
- created spec file


Thanks all.

-- 
Kind Regards,

Gavin Henry.
Managing Director.

T +44 (0) 1224 279484
M +44 (0) 7930 323266
F +44 (0) 1224 742001
E ghenry at suretecsystems.com

Open Source. Open Solutions(tm).

http://www.suretecsystems.com/