[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Fedora-packaging] Re: [Bug 198881] Review Request: perl-POE-Filter-IRCD



I suggested that Ralf put it on the schedule for discussion, but he
never did so I went ahead and did so.

Item: Tighten up Perl guidelines to disallow passing OPTIMIZE for
      noarch packages and tweak the Perl template to denote bits which
      must be left out of noarch packages.

Currently I see this as a stylistic issue and recognize the packager's
wish to follow the template here.  I think it's reasonable for me to
disagree with what he's adding to the packages without considering
them blockers.

In all truth, it's not really clear what's supposed to be done, and in
fact when doing my first reviews I was asking for the OPTIMIZE bit to
be _added_ to noarch packages to conform to the template.  I mean, all
we give people to go on is a template with a bunch of stuff that's
mildly cryptic at best and expect them to know which bits can go.  I
don't think it's fair or productive to fail to give them any hints
about what to do until Ralf blindsides them with statements about how
crappy their packages are.

So let's consider making it clear.  One snag is that I recall
discussion about adding a little bit of description to the Perl
template and being told that the template should be kept clean of
comments.  I'm only proposing two lines in the style of what's already
in the %files section; see the suggested patch I have attached.

Finally, note that I do not intend to review any more of Chris Weyl's
Perl packages until the committee clarifies this or until he decides
to drop the extraneous bits.

 - J<

--- spectemplate-perl.spec-orig 2006-07-19 09:44:04.621760113 -0500
+++ spectemplate-perl.spec      2006-07-19 09:44:34.674527337 -0500
@@ -21,6 +21,7 @@


 %build
+# Remove the OPTIMIZE bit for noarch packages
 %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
 make %{?_smp_mflags}

@@ -29,6 +30,7 @@
 rm -rf $RPM_BUILD_ROOT
 make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
+# Remove the following line for noarch packages
 find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
 find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
 chmod -R u+w $RPM_BUILD_ROOT/*


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]