[Fedora-packaging] GTK+ icon cache "bugs" on ScriptletSnippets

[Marcin Garski]

Hello,

I'm a maintainer of Krusader package in Fedora Extras. Recently I've 
recived bug report http://bugzilla.redhat.com/206650

yum install krusader

Installing: krusader                     ######################### [1/1]
No theme index file in '/usr/share/icons/locolor'.
If you really want to create an icon cache here, use --ignore-theme-index.

I've started to investigate it. The problem is GTK+ icon cache. I've 
used in my spec file scripts from:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets (GTK+ icon 
cache section).
This scripts doesn't check if %{_datadir}/icons/hicolor/index.theme 
exist, so in this case gtk-update-icon-cache generate such error.
My proposed resolution for this bug can be found in 
http://bugzilla.redhat.com/206860 but I will also paste it here:

if [ -x %{_bindir}/gtk-update-icon-cache ]; then
         if [ -f %{_datadir}/icons/hicolor/index.theme ]; then
                 touch --no-create %{_datadir}/icons/hicolor || :
                 %{_bindir}/gtk-update-icon-cache --quiet
%{_datadir}/icons/hicolor || :
         fi
fi

-- 
Best Regards
Marcin Garski