[Fedora-packaging] Re: Modifying upstream tarballs

[Axel Thimm]

On Mon, Jun 04, 2007 at 06:04:37PM -0500, Jason L Tibbitts III wrote:
> I understand that there are circumstances where the upstream tarballs
> need to be modified to removed content which is patented or cannot be
> redistributed for some reason.  However, should that be the extent of
> the permitted modifications?

Yes, the pre-%prep preparations should be minimal and easily
reproducable for the reviewer.

Would you like to formulate a guideline change for voting upon? It
seems like most people are on the same side, so it should be an easy
item.

> Take, for example, this comment from a current review ticket:
> 
> #Original from http://membres.lycos.fr/agisite/prof.zip includes
> #copyrighted executables. Generated new source by unzipping, removing
> #DOS-related content, running dos2unix on the text file, and changing
> #all filenames to lowercase for agistudio compatibility.
> 
> Now, everything except the removal of the executables could be done at
> %prep time in the spec, and that's how we'd insist that things be done
> in the normal case where the upstream tarball (or zipfile, in this
> case) needs no modification. 
> 
>  - J<
> 

-- 
Axel.Thimm at ATrpms.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-packaging/attachments/20070605/de8f69c8/attachment.sig>