[Fedora-packaging] Use of dos2unix in %prep

Richard W.M. Jones rjones at redhat.com
Wed Jan 14 09:00:49 UTC 2009


While a package was being reviewed, the reviewer picked up on a use of
the 'dos2unix --keepdate' command:

  https://bugzilla.redhat.com/show_bug.cgi?id=478640

The guidelines do indeed say not to use dos2unix, because quote "that
can cause build fail on FC3" (like I care).

  http://fedoraproject.org/wiki/Packaging/Guidelines#Rpmlint_Errors

But I've used dos2unix before, and it appears that using 'dos2unix
--keepdate' is a superior solution because it keeps the original
timestamp, and is generally simpler and more obvious to people reading
the specfile.

So is this guideline for real?

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/




More information about the Fedora-packaging mailing list