[Bug 191350] Review Request: perl-Spreadsheet-ParseExcel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Spreadsheet-ParseExcel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191350


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |tibbs at math.uh.edu
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-06-02 23:55 EST -------
rpmlint complains:

E: perl-Spreadsheet-ParseExcel no-binary

Unfortunately the package can't be noarch because of the map file, so this is
acceptable.

BuildRequires: perl is not necessary (not a blocker).

The documentation is over half of the size of the package, but the total package
size is small so I don't think it's necessary to place it in a subpackage.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* source files match upstream:
   6ee6257d4b66cb9e147a0b50603d1387  Spreadsheet-ParseExcel-0.2603.tar.gz
   6ee6257d4b66cb9e147a0b50603d1387  Spreadsheet-ParseExcel-0.2603.tar.gz-srpm
* latest version is being packaged.
O BuildRequires are proper (BR: perl is unnecessary).
* package builds in mock (development, x86_64).
O rpmlint has only ignorable complaints.
* final provides and requires are sane:
   perl(Spreadsheet::ParseExcel) = 0.2603
   perl(Spreadsheet::ParseExcel::Cell)
   perl(Spreadsheet::ParseExcel::Dump)
   perl(Spreadsheet::ParseExcel::FmtDefault) = 0.05
   perl(Spreadsheet::ParseExcel::FmtJapan) = 0.05
   perl(Spreadsheet::ParseExcel::FmtJapan2) = 0.05
   perl(Spreadsheet::ParseExcel::FmtUnicode) = 0.05
   perl(Spreadsheet::ParseExcel::Font)
   perl(Spreadsheet::ParseExcel::Format)
   perl(Spreadsheet::ParseExcel::SaveParser) = 0.01
   perl(Spreadsheet::ParseExcel::SaveParser::Workbook) = 0.06
   perl(Spreadsheet::ParseExcel::SaveParser::Worksheet)
   perl(Spreadsheet::ParseExcel::Utility)
   perl(Spreadsheet::ParseExcel::Workbook)
   perl(Spreadsheet::ParseExcel::Worksheet)
   perl-Spreadsheet-ParseExcel = 0.2603-1.fc6
  -
   perl(:MODULE_COMPAT_5.8.8)
   perl(Exporter)
   perl(Jcode)
   perl(OLE::Storage_Lite)
   perl(Spreadsheet::ParseExcel)
   perl(Spreadsheet::ParseExcel::FmtDefault)
   perl(Spreadsheet::ParseExcel::FmtJapan)
   perl(Spreadsheet::ParseExcel::Utility)
   perl(Spreadsheet::WriteExcel)
   perl(Unicode::Map)
   perl(constant)
   perl(overload)
   perl(strict)
   perl(vars)
* no shared libraries are present.
* package is not relocatable.
*  owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and the single test passes:
   PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl
   1..1
   ok 1
* no scriptlets present.
* code, not content.
O documentation is relatively small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.