[Bug 474864] Review Request: perl-Test-Signature - Automated SIGNATURE testing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474864


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2008-12-06 18:14:14 EDT ---
Your manual dependency on Test::Builder results in a duplicated dependency in
the final package; rpm -qp --requires
perl-Test-Signature-1.10-1.fc11.noarch.rpm yields:
  perl(Test::Builder)
  perl(Test::Builder) >= 0.17

which is pointless.  Admittedly rpm should not do this, but in the meantime it
is worth asking if you really need the manual versioned dependency.  Even F8,
which is going EOL soon, shipped with Test::Builder 0.32.

* source files match upstream.  sha256sum:
   08375ba37c26d3c062e4d54bf0042b51ab20f4f7ef5b9e5cb23cc0829d2befd5  
   Test-Signature-1.10.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
X final provides and requires:
   perl(Test::Signature) = 1.10
   perl-Test-Signature = 1.10-1.fc11
  =
   perl >= 0:5.004
   perl(:MODULE_COMPAT_5.10.0)
   perl(Exporter)
X  perl(Test::Builder)
X  perl(Test::Builder) >= 0.17
   perl(Test::More) >= 0.47
   perl(strict)
   perl(vars)

* %check is present and all tests pass:
   All tests successful.
   Files=2, Tests=2,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.01 cusr  0.00 
    csys =  0.03 CPU)

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.