[Bug 477122] Review Request: perl-Catalyst-Plugin-Authorization-Roles - Role based authorization for Catalyst based on Catalyst::Plugin::Authentication
bugzilla at redhat.com
bugzilla at redhat.com
Fri Dec 19 09:28:58 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=477122
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade at gmail.com
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2008-12-19 04:28:57 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1009025
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
afef214de7c8084c59fad8a07a640059
Catalyst-Plugin-Authorization-Roles-0.07.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=45, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.41 cusr 0.05
csys = 0.50 CPU)
+ Package perl-Catalyst-Plugin-Authorization-Roles-0.07-1.fc11 =>
Provides: perl(Catalyst::Plugin::Authorization::Roles) = 0.07
Requires: perl(Catalyst::Exception) perl(Scalar::Util) perl(Set::Object)
perl(strict) perl(warnings)
Suggestions:-
1) Not needed following in SPEC file
BuildRequires: perl >= 1:5.8.0
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-perl-devel-list
mailing list