[Bug 250804] Review Request: perl-Encode-Detect - Detects the encoding of data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Encode-Detect - Detects the encoding of data
Alias: perl-Encode-Detect

https://bugzilla.redhat.com/show_bug.cgi?id=250804


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841                      |
              nThis|                            |
         AssignedTo|nobody at fedoraproject.org    |ville.skytta at iki.fi
               Flag|                            |fedora-review+




------- Additional Comments From ville.skytta at iki.fi  2008-01-28 15:35 EST -------
Looks good, the only thing I have to add is that the %check section comes
usually after %install in specfiles.  I don't think there's a real technical
reason for that nowadays any more - a long time ago it (and some other hacks)
was required for rpmbuild versions that didn't grok %check.  But I think it's
good style nowadays still to follow the %prep, %build, %install, %check,
%post-and-friends, %files order of specfile sections.

Anyway, approved.  I'll also sponsor you, feel free to proceed with
http://fedoraproject.org/wiki/PackageMaintainers/Join

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.