[Bug 462254] Review Request: perl-Catalyst-Plugin-Session-Store-FastMmap - FastMmap session storage backend

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462254


Chris Weyl <cweyl at alumni.drew.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |cweyl at alumni.drew.edu
               Flag|                            |fedora-review?

Bug 462254 depends on bug 462253, which changed state.

Bug 462253 Summary: Review Request: perl-Cache-FastMmap - Uses an mmap'ed file to act as a shared memory interprocess cache
https://bugzilla.redhat.com/show_bug.cgi?id=462253

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED



--- Comment #1 from Chris Weyl <cweyl at alumni.drew.edu>  2008-11-12 19:30:31 EDT ---
Sorry for taking so long; I'd meant to pick up this review earlier but the Real
Job has me busy lately :-)

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=929961

There are 2 missing BR's for tests, Test::Pod and Test::Pod::Coverage; both of
these should be added as buildrequires.  perl(Path::Class) appears twice in the
requires, due to an explicit requires statement; this doesn't harm anything but
I'd suggest dropping the explicit requires from the spec.

The rpmlint warning you really can't do anything about :-)

=====> perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-1.fc9.noarch.rpm <=====
====> rpmlint
perl-Catalyst-Plugin-Session-Store-FastMmap.noarch: W:
filename-too-long-for-joliet
perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-1.fc9.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides for
perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-1.fc9.noarch.rpm
perl(Catalyst::Plugin::Session::Store::FastMmap) = 0.05
perl-Catalyst-Plugin-Session-Store-FastMmap = 0.05-1.fc9
====> requires for
perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-1.fc9.noarch.rpm
perl(:MODULE_COMPAT_5.10.0)  
perl(Cache::FastMmap) >= 1.13
perl(Catalyst::Plugin::Session) >= 0.09
perl(Catalyst::Utils)  
perl(File::Spec)  
perl(NEXT)  
perl(Path::Class)  
perl(Path::Class)  
perl(base)  
perl(strict)  

Source matches upstream:
a5c28758a3a212fcc0f374110bc7855c 
Catalyst-Plugin-Session-Store-FastMmap-0.05.tar.gz
a5c28758a3a212fcc0f374110bc7855c 
Catalyst-Plugin-Session-Store-FastMmap-0.05.tar.gz.srpm

License (perl) is correct.

Make the requires/buildrequires changes at the top of this review, and I'll
approve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.