[Bug 226285] Merge Review: perl-XML-Grove

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226285





--- Comment #32 from Patrice Dumas <pertusus at free.fr>  2008-10-15 10:16:24 EDT ---
(In reply to comment #29)
> (In reply to comment #24)
> > There are spurious provides coming from examples:
> > 
> > Provides: perl(MyHTML) perl(MyVisitor)
> 
> indeed.  So it seems the messages were almost right:
> 
> > perl-XML-Grove.noarch: W: doc-file-dependency
> > /usr/share/doc/perl-XML-Grove-0.46alpha/examples/my-html.pl
> > perl(XML::Parser::PerlSAX)
> 
> > perl-XML-Grove.noarch: W: doc-file-dependency
> > /usr/share/doc/perl-XML-Grove-0.46alpha/examples/visitor.pl
> > perl(XML::Parser::PerlSAX)

No, unless I am wrong it is about Requires, not about Provides, and I thing
that it is harmless since those Requires are Provided by the package or are
also
a Requires for the package.

> Had it mentioned perl(MyHTML) and perl(MyVisitor), respectively, the messages
> would have named the problem.
> 
> But the "rpmlint -i" hint says that it helps to clear the exec bit of the
> files.
> This is not true, the bit is cleared, yet the dependency generator brings in
> the wrong provides.

The perl dependencies generator doesn't take into account the exec
bit since .pm are not executables in general.

> Should I fight against the dependency generator somehow? gzipping the examples,
> rot13-encoding, renaming them, clearing the #! line or whatever... ???

I don't think so.

> Or is it enough to file a bug aginst the buggy dependency generator?

The bug I see is that rpmlint should say that perl(MyHTML) and perl(MyVisitor)
are doc file Provides dependencies, I don't see a bug in the dependency
generator.

And the rpmlint explanation is untrue, but rpmlint cannot know about all
dependency generators, especially those that are customized.

> To sum up, I still apply for the approval of the package in its current state
> in the cvs.

The perl(MyHTML) and perl(MyVisitor) provides should be removed. They 
are bogus provides, even though rpmlint doesn't find them...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.