[Bug 519395] cleanup patch: use better buildroot, nicer find coomands

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519395


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #2 from Ralf Corsepius <rc040203 at freenet.de>  2009-08-26 10:13:36 EDT ---
Stepan, I agree with your proposal on adopting the new buildroot, but I don't
agree on your "nice find" changes.

Rationale:
* Your proposal adds adds further external commands (pipe, xargs), where using
find's internal -exec is more efficient.
* Your proposal is sensitive to white space quoting, due to using xargs
(The original construct also is, due to missing quotes)
* -size 0 complies to POSIX, -empty doesn't.

May-be you should explain which issues you are trying to solve. I don't see
them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.