[Bug 519395] cleanup patch: use better buildroot, nicer find coomands

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519395





--- Comment #7 from Stepan Kasal <skasal at redhat.com>  2009-08-28 14:27:32 EDT ---
(In reply to comment #6)
> * You are fixing anything - Don't "try to fix" what is not broken.
> * You are adding new regressions,  

That is a good angle of view, and you convinced me to back out some of the
originally proposed changes.

But the command
   find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
is very confusing and its current state.
The first impression is, naturally, that it means "run rmdir with stderr
redirected to /dev/null".  Only after some concentration, the reader realizes
that the redirection applies to the whole find command.  Changing the position
of the redirection is the minimum that should be done (see the end of comment
#3).

But, still, running "find 2>/dev/null" is not nice.
What can be done about it?

It would be nice if we were able to instruct find to execute rmdir redirecting
its stderr; but all ways I can imagine are too complicated.

So I want to do a trade: sacrifice a tiny bit of portability in order to see
the error messages from find.  Does that sound fair?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.