[Bug 481257] Review Request: perl-Devel-SmallProf - Per-line Perl profiler

bugzilla at redhat.com bugzilla at redhat.com
Fri Jan 23 05:28:10 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481257


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-01-23 00:28:09 EDT ---
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1075567
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
498704ed1b888fc62b0c7092f8b590f5  Devel-SmallProf-2.02.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ make test gaveAll tests successful.
Files=5, Tests=14,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.05 cusr  0.02
csys =  0.09 CPU)
+ Package perl-Devel-SmallProf-2.02-1.fc11 =>
  Provides: perl(DB) perl(Devel::SmallProf) = 2.02
  Requires: perl(Time::HiRes) perl(strict)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-perl-devel-list mailing list