rpms/perl-Crypt-DSA/devel perl-Crypt-DSA-dsaparam.patch, NONE, 1.1 .cvsignore, 1.3, 1.4 perl-Crypt-DSA.spec, 1.11, 1.12 sources, 1.3, 1.4

Paul Howarth pghmcfc at fedoraproject.org
Sun Sep 13 19:20:49 UTC 2009


Author: pghmcfc

Update of /cvs/pkgs/rpms/perl-Crypt-DSA/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv17463

Modified Files:
	.cvsignore perl-Crypt-DSA.spec sources 
Added Files:
	perl-Crypt-DSA-dsaparam.patch 
Log Message:
* Fri Sep 11 2009 Paul Howarth <paul at city-fan.org> 1.16-1
- Update to 1.16 (first production release)
- New upstream maintainer -> change source URL
- Change buildreq which to perl(File::Which)
- Add new buildreqs perl(Crypt::DES_EDE3), perl(File::Spec), perl(IPC::Open3)
- Buildreq perl(Math::BigInt) >= 1.78
- Enable AUTOMATED_TESTING
- New test requirements:
  - perl(Perl::MinimumVersion) >= 1.20
  - perl(Test::CPAN::Meta) >= 0.12
  - perl(Test::MinimumVersion) >= 0.008
  - perl(Test::Pod) >= 1.26
- ToDo no longer present upstream, but add LICENSE and README as %doc
- Add runtime dependency on openssl (used for DSA parameter generation)
- Add patch for openssl dsaparam 1.0 compatibility (CPAN RT#49668)


perl-Crypt-DSA-dsaparam.patch:
 KeyChain.pm |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- NEW FILE perl-Crypt-DSA-dsaparam.patch ---
There's a slight change of output format in the openssl dsaparam command from
current versions to the forthcoming 1.0 release:

openssl 0.9.8k:

$ openssl dsaparam -text -noout 512
Generating DSA parameters, 512 bit long prime
This could take some time
........+..+++++++++++++++++++++++++++++++++++++++++++++++++++*
..+....................+................+.+................+................................+...+..+...........+.....+.............+.......+....+..............+.......+...+.....+.................+....+.............................+.......+..........+..+...+........+...............+......+..........+..+.....+............+.+..+...+.....+....+++++++++++++++++++++++++++++++++++++++++++++++++++*
DSA-Parameters: (512 bit)
    p:
        00:e6:6c:38:ce:8d:9f:1d:f0:7a:12:50:1e:ef:5c:
        73:fe:2e:7a:b0:ed:27:a0:96:c3:37:98:de:e9:b6:
        a2:e6:3a:97:9d:d5:c1:f8:1e:f4:2d:38:29:d8:08:
        ac:f1:20:28:51:54:cb:7a:a1:36:f6:e7:07:b1:cf:
        23:8d:6e:a1:33
    q:
        00:f4:7b:0c:a8:98:d7:e0:d0:3e:92:94:95:30:f5:
        21:0a:86:db:16:55
    g:
        00:c6:81:8d:32:72:6b:6b:a5:d2:90:fb:c2:31:c4:
        73:e0:1b:05:bb:17:5c:b2:b2:09:69:17:78:41:fc:
        99:a1:9b:07:ca:a7:02:5f:0e:1f:dd:35:05:90:ac:
        e8:66:47:ca:9a:1a:77:a4:f4:5e:65:66:64:bf:34:
        7d:fe:30:bf:5a

openssl 1.0 beta 3:

$ openssl dsaparam -text -noout 512
Generating DSA parameters, 512 bit long prime
This could take some time
.+........+++++++++++++++++++++++++++++++++++++++++++++++++++*
...+................+.....+..........+.+.+...........+.+............+............+......+...+.........................................+......+......+...............+...+....+..............+++++++++++++++++++++++++++++++++++++++++++++++++++*
    P:   
        00:82:ab:91:c2:9e:8e:c1:cd:cb:70:68:12:c9:44:
        90:20:97:e4:69:77:fc:53:ce:78:2c:3d:01:5c:69:
        42:45:bc:e7:06:2f:4e:75:d4:10:3b:ae:de:43:6f:
        d8:86:6d:1e:f9:1d:c5:8e:0d:92:ca:e7:23:2e:5b:
        42:26:09:88:3b
    Q:   
        00:f9:dc:55:fd:ca:48:8c:d4:e9:df:8a:25:6d:f7:
        82:5d:f8:34:34:3f
    G:   
        6b:75:a7:e5:ac:2e:3a:79:65:01:51:cb:78:a3:06:
        73:47:0a:b8:9c:de:68:36:c5:5e:44:02:fe:8a:73:
        73:bc:d3:1a:ec:08:40:da:b3:f6:e2:0b:14:e6:1c:
        0d:f5:ef:62:0e:bf:64:18:96:ee:87:f7:13:89:42:
        cc:69:6e:be

The change to labelling the parameters in upper case causes
Crypt::DSA::Keychain to fail like this (from the test suite):

Use of uninitialized value $parts{"p"} in concatenation (.) or string at /builddir/build/BUILD/Crypt-DSA-1.16/blib/lib/Crypt/DSA/KeyChain.pm line 69.
Use of uninitialized value $parts{"q"} in concatenation (.) or string at /builddir/build/BUILD/Crypt-DSA-1.16/blib/lib/Crypt/DSA/KeyChain.pm line 70.
Use of uninitialized value $parts{"g"} in concatenation (.) or string at /builddir/build/BUILD/Crypt-DSA-1.16/blib/lib/Crypt/DSA/KeyChain.pm line 71.
Can't locate object method "copy" via package "NaN" (perhaps you forgot to load "NaN"?) at /builddir/build/BUILD/Crypt-DSA-1.16/blib/lib/Crypt/DSA/Util.pm line 43.
# Looks like your test exited with 255 before it could output anything.

The patch changes the parameter labels to lower case, making the code
compatible with both old and new versions of openssl.

--- Crypt-DSA-1.16/lib/Crypt/DSA/KeyChain.pm	2009-09-11 13:45:37.000000000 +0100
+++ Crypt-DSA-1.16/lib/Crypt/DSA/KeyChain.pm	2009-09-12 22:56:31.000000000 +0100
@@ -53,7 +53,7 @@
             my $cur_part;
             foreach (@res) {
                 if (/^\s+(\w):\s*$/) {
-                    $cur_part = $1;
+                    $cur_part = lc($1);
                     next;
                 }
                 if (/^\s*((?:[0-9a-f]{2,2}:?)+)\s*$/) {


Index: .cvsignore
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Crypt-DSA/devel/.cvsignore,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -p -r1.3 -r1.4
--- .cvsignore	9 May 2006 09:29:15 -0000	1.3
+++ .cvsignore	13 Sep 2009 19:20:49 -0000	1.4
@@ -1 +1 @@
-Crypt-DSA-0.14.tar.gz
+Crypt-DSA-1.16.tar.gz


Index: perl-Crypt-DSA.spec
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Crypt-DSA/devel/perl-Crypt-DSA.spec,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -p -r1.11 -r1.12
--- perl-Crypt-DSA.spec	30 Jul 2009 22:21:16 -0000	1.11
+++ perl-Crypt-DSA.spec	13 Sep 2009 19:20:49 -0000	1.12
@@ -1,19 +1,32 @@
 Summary:	Perl module for DSA signatures and key generation
 Name:		perl-Crypt-DSA
-Version:	0.14
-Release:	9%{?dist}
+Version:	1.16
+Release:	1%{?dist}
 License:	GPL+ or Artistic
 Group:		Development/Libraries
 Url:		http://search.cpan.org/dist/Crypt-DSA/
-Source0:	http://search.cpan.org/CPAN/authors/id/B/BT/BTROTT/Crypt-DSA-%{version}.tar.gz
+Source0:	http://search.cpan.org/CPAN/authors/id/A/AD/ADAMK/Crypt-DSA-%{version}.tar.gz
+Patch0:		perl-Crypt-DSA-dsaparam.patch
 BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 Requires:	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 BuildArch:	noarch
-BuildRequires:	perl(Convert::PEM) >= 0.07
+BuildRequires:	perl(Convert::PEM)
+BuildRequires:	perl(Crypt::DES_EDE3)
 BuildRequires:	perl(Data::Buffer) >= 0.01
 BuildRequires:	perl(Digest::SHA1)
-BuildRequires:	perl(ExtUtils::MakeMaker), perl(Test::More)
-BuildRequires:	which, openssl
+BuildRequires:	perl(ExtUtils::MakeMaker)
+BuildRequires:	perl(File::Spec)
+BuildRequires:	perl(File::Which) >= 0.05
+BuildRequires:	perl(IPC::Open3)
+BuildRequires:	perl(Math::BigInt) >= 1.78
+BuildRequires:	perl(Perl::MinimumVersion) >= 1.20
+BuildRequires:	perl(Test::CPAN::Meta) >= 0.12
+BuildRequires:	perl(Test::More) >= 0.42
+BuildRequires:	perl(Test::MinimumVersion) >= 0.008
+BuildRequires:	perl(Test::Pod) >= 1.26
+BuildRequires:	openssl
+# Crypt::DSA::Keychain calls openssl for DSA parameter generation
+Requires:	openssl
 
 # Pull in Math::BigInt::GMP for GMP support for suitably recent versions of Math::BigInt
 # else use Math::GMP
@@ -33,18 +46,21 @@ verification, and key generation.
 %prep
 %setup -q -n Crypt-DSA-%{version}
 
+# Patch for openssl dsaparam 1.0 compatibility (CPAN RT#49668)
+%patch0 -p1
+
 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor
 %{__make} %{?_smp_mflags}
 
 %check
-%{__make} test
+%{__make} test AUTOMATED_TESTING=1
 
 %install
 %{__rm} -rf %{buildroot}
 %{__make} pure_install PERL_INSTALL_ROOT=%{buildroot}
 /usr/bin/find %{buildroot} -type f -name .packlist -exec %{__rm} -f {} ';'
-/usr/bin/find %{buildroot} -depth -type d -exec /bin/rmdir {} 2>/dev/null ';'
+/usr/bin/find %{buildroot} -depth -type d -exec /bin/rmdir {} ';' 2>/dev/null
 %{__chmod} -R u+w %{buildroot}/*
 
 %clean
@@ -52,7 +68,7 @@ verification, and key generation.
 
 %files
 %defattr(-,root,root,-)
-%doc Changes ToDo
+%doc Changes LICENSE README
 %{perl_vendorlib}/Crypt/
 %{_mandir}/man3/Crypt::DSA.3pm*
 %{_mandir}/man3/Crypt::DSA::Key.3pm*
@@ -63,10 +79,26 @@ verification, and key generation.
 %{_mandir}/man3/Crypt::DSA::Util.3pm*
 
 %changelog
-* Sat Jul 25 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.14-9
+* Fri Sep 11 2009 Paul Howarth <paul at city-fan.org> 1.16-1
+- Update to 1.16 (first production release)
+- New upstream maintainer -> change source URL
+- Change buildreq which to perl(File::Which)
+- Add new buildreqs perl(Crypt::DES_EDE3), perl(File::Spec), perl(IPC::Open3)
+- Buildreq perl(Math::BigInt) >= 1.78
+- Enable AUTOMATED_TESTING
+- New test requirements:
+  - perl(Perl::MinimumVersion) >= 1.20
+  - perl(Test::CPAN::Meta) >= 0.12
+  - perl(Test::MinimumVersion) >= 0.008
+  - perl(Test::Pod) >= 1.26
+- ToDo no longer present upstream, but add LICENSE and README as %%doc
+- Add runtime dependency on openssl (used for DSA parameter generation)
+- Add patch for openssl dsaparam 1.0 compatibility (CPAN RT#49668)
+
+* Sat Jul 25 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> 0.14-9
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
 
-* Thu Feb 26 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.14-8
+* Thu Feb 26 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> 0.14-8
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
 
 * Mon Nov  3 2008 Paul Howarth <paul at city-fan.org> 0.14-7


Index: sources
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Crypt-DSA/devel/sources,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -p -r1.3 -r1.4
--- sources	9 May 2006 09:29:15 -0000	1.3
+++ sources	13 Sep 2009 19:20:49 -0000	1.4
@@ -1 +1 @@
-5ff5ab4be5501f5547bbe46cdc3de442  Crypt-DSA-0.14.tar.gz
+a099204d57043767fbe31d639eb43b03  Crypt-DSA-1.16.tar.gz




More information about the Fedora-perl-devel-list mailing list