selinux + livecd-creator, May 20, 2008
sds at tycho.nsa.gov
Tue May 20 20:33:48 UTC 2008
On Tue, 2008-05-20 at 16:13 -0400, Eric Paris wrote:
> On Tue, 2008-05-20 at 16:08 -0400, Stephen Smalley wrote:
> > Use non-auditing forms of the
> > permission checks as getxattr may be called by unprivileged processes
> > commonly and lack of permission just means that we fall back to the
> > in-core context value, not a denial.
> If we do put this on list, lets make this an in code comment so its easy
> to remember in another 100 years when the next poor sap has to figure
> out what I am doing these days :)
Changed accordingly, and lightly tested.
Enable processes with CAP_MAC_ADMIN + mac_admin permission in policy
to get undefined contexts on inodes. This extends the support for
deferred mapping of security contexts in order to permit restorecon
and similar programs to see the raw file contexts unknown to the
system policy in order to check them.
security/selinux/hooks.c | 27 +++++++++++++++++++++++----
1 file changed, 23 insertions(+), 4 deletions(-)
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 4be1563..91b666a 100644
@@ -2754,9 +2754,7 @@ static int selinux_inode_removexattr(struct dentry *dentry, const char *name)
- * Copy the in-core inode security context value to the user. If the
- * getxattr() prior to this succeeded, check to see if we need to
- * canonicalize the value to be finally returned to the user.
+ * Copy the inode security context value to the user.
* Permission check is handled by selinux_inode_getxattr hook.
@@ -2765,12 +2763,33 @@ static int selinux_inode_getsecurity(const struct inode *inode, const char *name
char *context = NULL;
+ struct task_security_struct *tsec = current->security;
struct inode_security_struct *isec = inode->i_security;
if (strcmp(name, XATTR_SELINUX_SUFFIX))
- error = security_sid_to_context(isec->sid, &context, &size);
+ * If the caller has CAP_MAC_ADMIN, then get the raw context
+ * value even if it is not defined by current policy; otherwise,
+ * use the in-core value under current policy.
+ * Use the non-auditing forms of the permission checks since
+ * getxattr may be called by unprivileged processes commonly
+ * and lack of permission just means that we fall back to the
+ * in-core context value, not a denial.
+ error = secondary_ops->capable(current, CAP_MAC_ADMIN);
+ if (!error)
+ error = avc_has_perm_noaudit(tsec->sid, tsec->sid,
+ if (!error)
+ error = security_sid_to_context_force(isec->sid, &context,
+ error = security_sid_to_context(isec->sid, &context, &size);
error = size;
National Security Agency
More information about the fedora-selinux-list