enchant change (was: Re: rawhide report: 20091211 changes)

[Adam Miller]

On Sun, Dec 13, 2009 at 10:00 AM, Matthias Clasen <mclasen at redhat.com> wrote:
> On Sat, 2009-12-12 at 15:54 -0600, Adam Miller wrote:
>> I thought that at first and contacted Midori upstream and they said it
>> was a packaging bug in enchant because the debian enchant package they
>> develop against provides the .so
>
> Sounds like there is some library / module confusion here. Is enchant
> meant to be linked against (which the placement in libdir seems to
> indicate), or is it meant to be dlopened (which including the .so in the
> main package seems to imply).
>
> If midori is dlopening the enchant library for false fear of
> dependencies, then this clearly is a midori issue. If it wants to play
> such games, it needs to look for *.so.<n>
>
>

Yes, it appears upstream is bypassing the linking to avoid the dependency.

static GList*
midori_preferences_get_spell_languages (void)
{
  //  <SNIP>

    if (!enchant_broker_list_dicts && g_module_supported ())
    {
        GModule* module;
        if (!(module = g_module_open ("libenchant.so", G_MODULE_BIND_LOCAL)))
            return NULL;

// <SNIP>

I will close the bug in bugzilla against enchant and work with
upstream on getting this corrected.

-Adam

-- 
http://maxamillion.googlepages.com
---------------------------------------------------------
()  ascii ribbon campaign - against html e-mail
/\  www.asciiribbon.org   - against proprietary attachments