[fedora-virt] ANNOUNCE: Augeas support added to libguestfs

[Richard W.M. Jones]

On Sun, Apr 12, 2009 at 02:35:34PM +0200, Ján ONDREJ (SAL) wrote:
> On Sun, Apr 12, 2009 at 11:56:37AM +0100, Richard W.M. Jones wrote:
> > On Sun, Apr 12, 2009 at 11:53:10AM +0100, Richard W.M. Jones wrote:
> > > > guestfsd-augeas.o: In function `do_aug_load':
> > > > /usr/src/rpmbuild/BUILD/libguestfs-0.8/daemon/augeas.c:272: undefined reference to `aug_load'
> > > > guestfsd-augeas.o: In function `do_aug_defnode':
> > > > /usr/src/rpmbuild/BUILD/libguestfs-0.8/daemon/augeas.c:113: undefined reference to `aug_defnode'
> > > > guestfsd-augeas.o: In function `do_aug_defvar':
> > > > /usr/src/rpmbuild/BUILD/libguestfs-0.8/daemon/augeas.c:97: undefined reference to `aug_defvar'
> > > > collect2: ld returned 1 exit status
> > > > 
> > > > Can I disable augeas usage when building rpm?
> > [...]
> > > What was the problem with just installing augeas-devel?  It's in
> > > Fedora 10 updates & Rawhide.
> > 
> > Looking at this again, I wonder if the problem is that your version of
> > Augeas is too old?  It seems like the specific calls which fail are
> > aug_load, aug_defnode and aug_defvar, and I think those were recently
> > added to Augeas.
> > 
> > If that is the case, then it either needs a more specific dependency
> > check, or else we need to test if these calls are present in
> > daemon/configure.ac and disable them in daemon/augeas.c.
> 
> I have augeas-devel-0.3.6-1.fc10.i386 and there is 0.5.0 in rawhide.
> May be my library is too old.

If you have the time I think it's worth coming up with a small patch
to check for these functions in daemon/configure.ac and conditionally
compile them in daemon/augeas.c, ie:

int do_aug_load (void)
{
#ifdef HAVE_AUG_LOAD
  /// old code
#else
  reply_with_error ("aug_load function is not available");
#endif
}

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top