[fedora-virt] Re: virt-inspector calling guestfs_umount_all() before launch()?

[Richard W.M. Jones]

On Tue, Jun 02, 2009 at 08:51:53AM -0500, Charles Duffy wrote:
> On Tue, Jun 2, 2009 at 8:37 AM, Richard W.M. Jones <rjones at redhat.com>wrote:
> 
> > On Thu, May 28, 2009 at 10:53:20PM +0100, Richard W.M. Jones wrote:
> > > On Thu, May 28, 2009 at 04:19:21PM -0500, Charles Duffy wrote:
> > > > Just curious -- do you intend to push the patch ("-snapshot" in
> > > > virt-inspector) into the tree?
> > >
> > > I guess we can, but is there a better way?
> >
> > Right, had a think about this over the weekend, found and read the
> > qemu documentation, and I have added this patch:
> >
> >
> > http://git.et.redhat.com/?p=libguestfs.git;a=commitdiff;h=bfdc03be234d6d95f18450846433bce4f97e184c
> >
> > It adds a 'guestfs_add_drive_ro' call, which is equivalent to the qemu
> > parameter: -drive file=<filename>,snapshot=on
> 
> 
> Yay!
> 
> That said -- might I suggest that guestfish use add_drive_ro() for all --add
> options if --ro is specified on the command line at startup?
> 
> I'll happily work up a patch myself once I get into the office in a few
> hours, if you'd prefer.

Yes, good idea, please send a patch.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v